search

david-cattermole / mayaMatchMoveSolver

A Bundle Adjustment solver for MatchMove related tasks.
https://david-cattermole.github.io/mayaMatchMoveSolver/
Other
101 stars 29 forks source link

Solver UI - Window Values Are Retained After "File > New" #223

Closed david-cattermole closed 3 years ago

david-cattermole commented 3 years ago

Problem

After opening a mmSolver window, then closing the scene file (using "File > New" or "File > Open"), the window is kept in memory, and when the same window is opened the widget values will be retained.

Expected behavior: When a scene is closed, the windows that were opened in the scene should be closed and "deleted" or values reset to defaults.

Actual behavior: In mmSolver v0.3.13, when a Maya scene is opened, then Solver UI is opened and widget values edited, then the Maya scene is closed, and the window is re-opened the widget values will not be defaults.

Steps to Reproduce

  1. Open Maya.
  2. Open Solver UI window, and enable checkbox "Evaluate Complex Node Graphs".
  3. Use "File > New", to close the current scene file and create a blank new file.
  4. Open Solver UI window, notice "Evaluate Complex Node Graphs" is still checked on (default is off).

Software Versions

david-cattermole commented 3 years ago

This was fixed and addressed as part of #222, and specifically with commits: 3c9a43b9d6f8847f2760640d42f5d60afbaa3b18 3db9168a26537430be8a9b1d61d768830c595c80 and e435461e9a993a08a18b83ed86cac882553c57fe

The issue was fixed by automatically triggering all BaseMayaWindow class instances to close when an event from Maya is triggered. Maya will run the event when the condition of sceneFlushing is true, which usually happens when the user uses File > New or File > Open menus (or the respective MEL/Python commands).

Like #222 this will be released in v0.3.14.