david-cattermole / mayaMatchMoveSolver

A Bundle Adjustment solver for MatchMove related tasks.
https://david-cattermole.github.io/mayaMatchMoveSolver/
Other
101 stars 29 forks source link

mmSolver general tools update #242

Closed bpatchasaheb closed 2 years ago

bpatchasaheb commented 2 years ago
david-cattermole commented 2 years ago

Thanks @bpatchasaheb, this looks great!

I will port this to the v0.4.x release to get things started.

I notice there are some empty lines added to some files and file permissions changed for some files. I am assuming these changes were not needed or necessary?

The names for some of the tools (such as createcamerabodytrackscalerigbake) seem very long and hard-codes terminology that might not be common in all studios (for example "Body Track"), so I need to think of more simple name. It's the same for some of the UI labels, I find them a little confusing and I think we should consider simpler names.

As discussed I think we should not remove the Create Controller (v2) tool from the menu and keep both UIs and tools. The new Create Controller UI is for creating multiple controllers at once, but for backwards compatibility of user experience I think the older Create Controller UI is easier for people to understand. The "v2" tool could be named something like "Create Controller (single)". The "v3" tool could be named something like "Create Controller (multiple)".

I'll need to dig in deeper as this is a large amount of code. I'll have a closer look in the next few days.