search

david-cortes / MatrixExtra

(R) Efficient methods and operators for the sparse matrix classes in 'Matrix' (esp. CSR format or "RsparseMatrix")
https://cran.r-project.org/package=MatrixExtra
GNU General Public License v3.0
19 stars 3 forks source link

Correct isinf() scope. #4

Closed cbrueffer closed 2 years ago

cbrueffer commented 2 years ago

Add std scope to isinf(), as already done in other places across the repo. This fixed the Windows build in conda-forge (https://github.com/conda-forge/staged-recipes/pull/17116).

david-cortes commented 2 years ago

Thanks for the PR. Guess I'll additionally need add an include <cmath> then, since its functions are already being used elsewhere and not explicitly included unless also bundling the robinmap dependency.

~Do you have some log for a failing build of this package?~ Nevermind, managed to find an error log that ended up loading correctly in the link that you posted. For some reason, the logs on the last commit show a loading error from the azure webpage though.

cbrueffer commented 2 years ago

It's possible, but I'm not sure. Here the build log in question, just in case.

matrixextra-build-failure.txt .