search

david-cortes / hpfrec

Python implementation of 'Scalable Recommendation with Hierarchical Poisson Factorization'.
http://hpfrec.readthedocs.io
BSD 2-Clause "Simplified" License
79 stars 19 forks source link

Switch to setuptools #5

Closed yetanotherion closed 5 years ago

yetanotherion commented 5 years ago

Switch to setuptools

david-cortes commented 5 years ago

Thanks for the change, but I’d first want to ask: does distutils generate some undesired behavior? I understand there are some differences such as where they put non-Python files or such, but for a package like this that does not have anything special, is there any difference? Doesn’t a pip install end up anyway using setuptools? Also, given that setuptools is not part of standard Python and that it can throw errors in situations in which distutils works fine, could you make a fallback mechanism? e.g.

try:
    from setuptools …
except:
    from distutils …
yetanotherion commented 5 years ago

does distutils generate some undesired behavior?

I was not able to generate a wheel with distutils.

could you make a fallback mechanism?

That's a good idea. Still are you ok to support both setuptools and distutils?

david-cortes commented 5 years ago

Fair enough, didn’t envision building wheels for the package. Please proceed then with switching it to setuptools with a fallback to distutils.

yetanotherion commented 5 years ago

Thanks!