search

david-cortes / isotree

(Python, R, C/C++) Isolation Forest and variations such as SCiForest and EIF, with some additions (outlier detection + similarity + NA imputation)
https://isotree.readthedocs.io
BSD 2-Clause "Simplified" License
186 stars 38 forks source link

fixed build with older CMake and Visual Studio 2017 #59

Closed 2128506 closed 5 months ago

2128506 commented 5 months ago

This PR makes fixes necessary for building libisotree using Visual Studio 2017. Two problem fixed: one is older CMake shipped with VS 2017, and other is mismatched declaration of stream operators.

david-cortes commented 5 months ago

Thanks for the PR.

However, adding the visibility macro to the friend declaration breaks the compilation in other platforms like linux.

Would you be able to modify the PR to add this part only on windows?

david-cortes commented 5 months ago

Thanks, merged.