search

david-dick / firefox-marionette

This is a client module to automate the Mozilla Firefox browser via the Marionette protocol
https://metacpan.org/dist/Firefox-Marionette
Other
12 stars 3 forks source link

Version 1.36 fails on macOS 13.2.1, Perl 5.36.0, Firefox 112.0.1 #22

Closed toreau closed 1 year ago

toreau commented 1 year ago

Version 1.36 fixed many of the failed tests in 1.35, but there's one left:

t/01-marionette.t .. 1080/? 
#   Failed test 'Percentage visible is 100% for the username field:95.4545454545455'
#   at t/01-marionette.t line 4131.
david-dick commented 1 year ago

Can you provide any assistance as to how this is happening? As previously, I cannot replicate this issue on my OS X platform or see the issue on the github OS X platform. I would like you to run a script on your OS X machine and give me a screenshot of the result.

toreau commented 1 year ago

I cloned the repo and changed the test to check if platform_name is mac (not darwin);

if ($firefox->capabilities->platform_name eq 'mac') {
  ok($percentage >= 95, "Percentage visible is at least 95% for the username field: $percentage");
}
else {
  ok($percentage == 100, "Percentage visible is 100% for the username field: $percentage");
}

Not pretty, but it works. 😊

To be clear: $^O returns darwin, while the platform_name returns mac for some reason I haven't bothered to dive into. 😊

david-dick commented 1 year ago

that will do. Stand by.

david-dick commented 1 year ago

Okay, version 1.37 has been released. It would be good to understand why this problem is happening, anything you could do to help with this would be most appreciated.

toreau commented 1 year ago

Successfully managed to install it from CPAN now. Great work! 😊

PS! Maybe create a macOS CI workflow?

david-dick commented 1 year ago

I've created this one and it's been running fine for a while.