david-eom / CS2103T-PE

0 stars 0 forks source link

Logic UML diagram can't tell whether it's class inheritance or interface implementation #13

Open david-eom opened 3 years ago

david-eom commented 3 years ago

In the Logic.java UML diagram, since the arrow from LogicManager to Logic interface is way too short, the developers can't tell if it is an inheritance (line) or implementation of interface (dotted line).

截圖 2021-11-12 下午5.26.31.png

nus-pe-bot commented 3 years ago

Team's Response

There is a gap between the line and the arrow head which would still prompt the reader/developer that it is an implementation of the interface. Also it would not make sense for it to be an inheritance since a concrete class cannot inherit an interface.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that the user can still be somewhat prompted to think that this is an implementation.

Although it does not affect understanding, I still think that this is still a cosmetic issue (spacing) and it fits perfectly under the definition of severity.veryLow bug, as indicated below.

截圖 2021-11-17 上午12.55.00.png