search

david-eom / CS2103T-PE

0 stars 0 forks source link

Incorrect loop condition under the sequence diagram under "Task Feature" #17

Open david-eom opened 3 years ago

david-eom commented 3 years ago

In the sequence diagram of deleting all done tasks as attached below:

截圖 2021-11-12 下午5.35.15.png

The loop condition is a bit weird. [List < Task > ] is not really a boolean or an integer for the loops to be iterated. 截圖 2021-11-12 下午5.35.32.png

A better choice would be List < Task > .length() times or the like.

nus-pe-bot commented 3 years ago

Team's Response

We believe that the notation is still correct since it means "for every element of the list", even though your suggestion is also valid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: According to the textbook, the notation within [] (the square brackets) must be a condition. It has to be a boolean, or the number of times. Examples include [hasNext] or [5 times].

截圖 2021-11-17 上午12.39.07.png

However, the team simply used [List &lt Task &gt]. I would like to point out that although syntax like while [certain list]: is valid in languages like Python, List &lt Task &gt in Java simply means a generic class. "Believe that the notation means 'for every element of the list'" does not constitute a valid defence in my opinion.