search

david-eom / CS2103T-PE

0 stars 0 forks source link

Incorrect exception thrown for index 0 #8

Open david-eom opened 3 years ago

david-eom commented 3 years ago

To reproduce:

  1. type clear to purge the databse
  2. type editLink 1 n/asdf, the error The link index provided is invalid pops up
  3. type editLink 0 n/asdf, we would expect the same error. But instead the error Invalid command format is being thrown.

This bug persists for all index based commands.

For non-zero indexes: 截圖 2021-11-12 下午4.55.28.png

For zero indexes: 截圖 2021-11-12 下午4.55.08.png

nus-pe-bot commented 3 years ago

Team's Response

We only accept integers between 1 and 2147483647 for the index, which is indicated in the error message. In both the UG and the app itself, a command with an index out of the range is defined as having invalid format.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]