search

david-eom / CS2103T-PE

0 stars 0 forks source link

Addlink for files on macOS does not function as described. #9

Open david-eom opened 3 years ago

david-eom commented 3 years ago

By following the instruction in user guide: 截圖 2021-11-12 下午4.59.16.png

截圖 2021-11-12 下午4.59.51.png

The file path is copied as /Users/David/Desktop/visa.pdf.

However, when we type in addLink n/visa a//Users/<username>/Desktop as required by the UG, the following error is being thrown: 截圖 2021-11-12 下午5.01.10.png

User then have to manually add in the file:// in front, and he/she might be confused about whether it is 3 forward slashes (addLink n/visa a/file:///Users/<username>/Desktop) or 2 forward slashes i.e. (addLink n/visa a/file://Users/<username>/Desktop).

nus-pe-bot commented 3 years ago

Team's Response

We believe the addLink function is functioning as intended. The command typed in the screenshot is incorrect as the file path does not begin with "file://", and the error message shown is correct and functions as intended.

Requiring users to manually type in "file:/" is not a bug, since it is required to distinguish between website addresses and local file paths, and also clearly stated in UG and error message.

While the phrasing of our error message can be improved to state that there're 2 forward slashes, the examples in our UG should sufficiently inform users that there're 2 slashes.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]