search

david-fisher / 320-S20-Track2

Integration Track 2
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

DELETE /options #105

Closed jakegoldman closed 4 years ago

jakegoldman commented 4 years ago

There's technically still one bug. Deleting an appointment_type requires a different process because of how the database is set up, and right now the lambda returns a 200 OK instead of a 404 Not Found when called on an appointment_type that has already been deleted. The actual functionality is the same and this is a use case that probably won't show up anyway, so I didn't feel that it was worth it to do an entire extra query/check to get the proper response.

WildeFire7 commented 4 years ago

I agree that the extra query isn't worth it here. Nice job covering/catching all the potential errors.