search

david-guenault / shinken-packs

2 stars 3 forks source link

Receiver daemon is not considered #3

Closed mohierf closed 9 years ago

mohierf commented 9 years ago

In templates.cfg, missing receiver in _shinken_daemons list ...

Anyway ... check_shinken2.py does not take care of receiver and must also be fixed for this.

david-guenault commented 9 years ago

yup saw this some days ago. And there was much more thant that. Curently fixing it.

Thx for report

mohierf commented 9 years ago

Should not be better to use a tag as "shinken2" instead of "arbiter2" and an aggregation "shinken2" for the services ?

Before my fix : image

After a small fix :

image

david-guenault commented 9 years ago

also right. I'm curently fixing some issues since the tls integration (now plugin support ss/tls)

david-guenault commented 9 years ago

Can you submit a pr for that ?

mohierf commented 9 years ago

I tried so ... but I cannot !

I cloned your repo and created a local branch, then I commited my modifications and built a PR for my new branch. But I cannot : 

git push --set-upstream origin Shinken2-aggregation
remote: Permission to david-guenault/shinken-packs.git denied to 85268319e784cef9fe2c742e719c48adaaf36a3a.
fatal: unable to access 'https://github.com/david-guenault/shinken-packs.git/': The requested URL returned error: 403
david-guenault commented 9 years ago

You have to push to tour repo ( fork) then use github to sublit pr. It's that simple Le 10 mai 2015 17:26, "Frédéric MOHIER" notifications@github.com a écrit :

I tried so ... but I cannot !

I cloned your repo and created a local branch, then I commited my modifications and built a PR for my new branch. But I cannot :

git push --set-upstream origin Shinken2-aggregation remote: Permission to david-guenault/shinken-packs.git denied to 85268319e784cef9fe2c742e719c48adaaf36a3a. fatal: unable to access 'https://github.com/david-guenault/shinken-packs.git/': The requested URL returned error: 403

— Reply to this email directly or view it on GitHub https://github.com/david-guenault/shinken-packs/issues/3#issuecomment-100655484 .

mohierf commented 9 years ago

Thanks ... I tried to PR directly into your repo :/P