Closed bcombes closed 11 months ago
Hi @bcombes, thanks for your report! I see you right. The key for asset url is 'link' and not 'url'. If you want to submit a PR, here are the places that need the changes:
https://github.com/david-lev/pywa/blob/master/pywa/types/template.py#L905 https://github.com/david-lev/pywa/blob/master/pywa/types/template.py#L919 https://github.com/david-lev/pywa/blob/master/pywa/types/template.py#L933
Hi david, I would love to and I already fixed on my local, but seems I don't have permissions to create a PR on the project'
Thanks! To open pr you must fork this repo, commit your changes to your fork and then open PR
I uploaded a new version
@bcombes Please update the directory (pip3 install -U pywa
)
Thanks david! great library by the way
Discussed in https://github.com/david-lev/pywa/discussions/14