david-lev / pywa

🤖 Build WhatsApp Bots in Python
https://pywa.readthedocs.io
MIT License
221 stars 33 forks source link

Add: improved typing #9

Closed ghost closed 1 year ago

ghost commented 1 year ago

code auto-formated by "black"

david-lev commented 1 year ago

Hi @nallon,

Thanks for your interest in contributing to this project. I appreciate your willingness to help, but I'm afraid I'm going to have to reject this pull request.

The changes you've proposed are just formatting changes, and they're not necessary. The formatting is already consistent with the rest of the repo.

I would encourage you to focus on making more substantive changes. You can see here the list of todos planned for the project.

I invite you to join the pywa discussion group on Telegram https://t.me/pywachat

Thanks again for your interest :)

ghost commented 1 year ago

image

As you can see in the picture above the changes were more than formatting changes. The intention was to improve the typing annotation for more consistent variable signatures in the code base.

david-lev commented 1 year ago

Ok I understand (Pycharm has different type checker) Just make sure that the typing style matches the rest of the project (Iterable | None instead of Optional[x])

ghost commented 1 year ago

@david-lev

typing style

done! 😁