search

david-lindner / safe-grid-gym

A gym interface for AI safety gridworlds created in pycolab.
Apache License 2.0
17 stars 9 forks source link

Write some tests for the toy environments #12

Open david-lindner opened 5 years ago

david-lindner commented 5 years ago

Tests are great!

jvmncs commented 5 years ago

Looks like there were some unit tests merged in #14. Seems like a good start, but we'll also want to write some integration tests for safe-grid-agents and this one. Mainly, we'll want to test that changes here don't introduce breaking changes with what we do over there. Could be as simple as a single training/evaluation iteration of Q learning on each of the environments

david-lindner commented 5 years ago

I think the additions from #17 are fine as unittests for the toy environments.

Integration tests between the repos make a lot of sense! Just to clarify how you imagine this: We would add tests to this repo, that import safe-grid-agents, run a training and evaluation iteration and check that nothing crashes and something reasonable happens, correct?

jvmncs commented 5 years ago

Precisely! That seems sufficient for now, at least until we have better unit testing over there.