search

david-lindner / safe-grid-gym

A gym interface for AI safety gridworlds created in pycolab.
Apache License 2.0
17 stars 9 forks source link

Travis #19

Closed david-lindner closed 5 years ago

david-lindner commented 5 years ago

Use travis for testing as of #13 and generalize toy gridworld array dtype, see #16

alok commented 5 years ago

I thought the version for this was 3.5 rather than 3.6, something to do with google cloud? @jvmancuso you told me about this earlier

david-lindner commented 5 years ago

Ah good point, I am not sure about that. I have been using 3.6, because it was set in the safe-grid-agents .travis.yml. So this would have to be changed as well

alok commented 5 years ago

I'd wait for @jvmancuso to weigh in before changing anything since gcp may have finally updated to 3.6

jvmncs commented 5 years ago

3.5 is the current default on GCP still -- see here for an example: https://cloud.google.com/deep-learning-vm/docs/images similarly, ML engine allows options for 2.7 or 3.5, but not 3.6 or 3.7

david-lindner commented 5 years ago

Apparently black only supports python 3.6+, which is unfortunate. My solution is pretty hacky: running travis for 3.5 without black and for 3.6 with black, but I guess it works.