david-loe / abrechnung

Reisekostenabrechnung inkl. automatischer Pauschalen Berechnung auch fΓΌr internationale Reisen
GNU Affero General Public License v3.0
12 stars 2 forks source link

make forms dynamic to enable custom locales to be used in production #106

Closed david-loe closed 1 month ago

david-loe commented 1 month ago

Fixes #105

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple controller files in the backend and frontend, primarily focusing on adding new methods to convert various Mongoose schemas into Vueform schemas. These methods are accessible via specific GET endpoints and utilize a new utility function, mongooseSchemaToVueformSchema. Additionally, several JSON schema files related to forms have been deleted, and the frontend components have been updated to dynamically fetch form schemas instead of relying on static imports.

Changes

File Path Change Summary
backend/controller/countryController.ts Added method getCountryForm() in CountryAdminController to convert countrySchema to Vueform schema.
backend/controller/currencyController.ts Added method getCurrencyForm() in CurrencyAdminController to convert currencySchema to Vueform schema.
backend/controller/healthInsuranceController.ts Added method getHealthInsuranceForm() in HealthInsuranceAdminController to convert healthInsuranceSchema to Vueform schema.
backend/controller/organisationController.ts Added method getOrganisationForm() in OrganisationAdminController to convert organisationSchema to Vueform schema.
backend/controller/projectController.ts Added method getProjectForm() in ProjectAdminController to convert projectSchema to Vueform schema.
backend/controller/settingsController.ts Added method getSettingsForm() in SettingsAdminController to convert settingsSchema to Vueform schema.
backend/controller/userController.ts Added method getUserForm() in UserAdminController to convert userSchema to Vueform schema.
backend/models/vueformGenerator.ts Replaced generateForms with mongooseSchemaToVueformSchema for converting Mongoose schemas to Vueform schemas.
backend/server.ts Removed various imports and a conditional block related to development form generation logic.
common/forms/*.json Deleted multiple JSON schema files for forms (country, currency, health insurance, organisation, project, settings, user).
frontend/src/components/settings/elements/*.vue Updated multiple components to dynamically fetch form schemas during lifecycle hooks instead of using static imports.

Assessment against linked issues

Objective Addressed Explanation
Enable dynamic forms for custom locales in production (#105) βœ…
Implement new methods to convert schemas to Vueform format βœ…

Possibly related PRs

🐰 In the land where forms do play,
New methods bloom, bright as day.
With schemas fetched, no more static,
Dynamic forms, oh so fantastic!
From country to settings, all align,
In Vueform's embrace, they brightly shine! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.