Closed david-loe closed 1 month ago
The changes in this pull request involve significant updates to several backend files, particularly affecting function signatures and internal logic. The getDateOfSubmission
function has been renamed and modified to return comprehensive report objects instead of just dates. Additionally, PDF report generation files have been updated to reflect these changes, including layout adjustments and new logic for displaying submission dates. Localization files have also been enhanced with new labels for clarity in the user interface.
File Path | Change Summary |
---|---|
backend/helper.ts | - Renamed getDateOfSubmission to getSubmissionReportFromHistory , changed return type to Promise<ITravel | IExpenseReport | IHealthCareCost | null> . - Updated logic to return historyReport object. - Enhanced documentFileHandler for better file upload handling. |
backend/pdf/expenseReport.ts | - Replaced getDateOfSubmission with getSubmissionReportFromHistory in drawDates , renamed date column from date to value , adjusted width from 55 to 95 . - Updated logic in drawSummary to conditionally include refund sum. |
backend/pdf/healthCareCost.ts | - Similar updates as expenseReport.ts , including changes to drawDates and drawSummary functions. |
backend/pdf/travel.ts | - Similar updates as expenseReport.ts , with adjustments in drawDates and new logic for fetching submission dates. |
common/locales/de.json | - Added new labels: "approvedBy": "Genehmigt von" and "examinedBy": "Geprüft von" . |
common/locales/en.json | - Added new labels: "approvedBy": "Approved by" and "examinedBy": "Examined by" . |
🐇 In the land of code where rabbits play,
New functions bloom, brightening the day.
Reports now shine with clarity and grace,
Labels added, making a welcoming space.
With every change, our work takes flight,
Hopping along, everything feels right! 🌼✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
addresses #79
Summary by CodeRabbit
New Features
Bug Fixes
Documentation