david-loe / abrechnung

Reisekostenabrechnung inkl. automatischer Pauschalen Berechnung auch für internationale Reisen
GNU Affero General Public License v3.0
12 stars 2 forks source link

wrong lump sum used for last day of trip to foreign country. #18

Closed blattms closed 10 months ago

blattms commented 10 months ago

Looks quite nice already.

I assume here that this is for Germany. If I input a one day or multi day trip to a foreign country, then for the last day the lump sum of the country I return to is used. It should be the value for the last foreign country visited for business purposes.

Even more complicate if there is an overnight stop over on the way back in another country. The lump sum of that country should be used for the day before the day returning and for the day returning that the one of the last country visited for business purposes.

david-loe commented 10 months ago

Thanks for pointing that out! You're right it says:

Bei der Abreise vom Ausland in das Inland oder vom Inland in das Ausland ist der entsprechende Pauschbetrag des letzten Tätigkeitsortes maßgebend.

Do you have a smart idea on how to guess the letzter Tätigkeitsort without user input? 😅
Suppose the stop on the way back has a business purpose.. How should the system know? And I think I already need to much user input.. 🙆‍♂️

blattms commented 10 months ago

I have an idea. You have a country when a business travel is proposed. Just use that one for the last day when you travel back.

If that country is editable then users can adjust for complicated cases.

david-loe commented 10 months ago

Hmm.. Doesn't this only cover travels with just one country where business has happend?

But maybe this can be the default case, and if the travel ends with multiple country stops the user is prompted to put in the country where the last business happend

blattms commented 10 months ago

yep that is true. That is why user would need to be able to change the country in the application later.