search

david-loe / abrechnung

Reisekostenabrechnung inkl. automatischer Pauschalen Berechnung auch für internationale Reisen
GNU Affero General Public License v3.0
12 stars 2 forks source link

make deletions safe #98

Closed david-loe closed 2 months ago

david-loe commented 2 months ago

fixes #97

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes introduce a new error handling mechanism in the backend code, specifically focusing on deletion operations across various controllers. A ConflictError class is added to handle scenarios where deletions cannot proceed due to existing references in related models. The deleteOne method in the Controller class is updated to incorporate reference checks, and similar updates are made to specific deletion methods in the OrganisationAdminController, ProjectAdminController, and UserAdminController. Additionally, localization files are updated to include conflict alert messages in English and German.

Changes

File Path Change Summary
backend/controller/controller.ts Added referenceChecks property to DeleterOptions interface. Updated deleteOne method to throw ConflictError if references exist during deletion.
backend/controller/error.ts Introduced ConflictError class extending ClientError, with status set to 409 and name set to 'alerts.conflict'.
backend/controller/organisationController.ts Modified deleteOrganisation method to include referenceChecks for checking associated projects before deletion.
backend/controller/projectController.ts Updated deleteProject method to include reference checks against ExpenseReport, Travel, and HealthCareCost models before deletion.
backend/controller/userController.ts Enhanced deleteUser method with reference checks for Travel, ExpenseReport, and HealthCareCost models, including conditions for checking historic records.
backend/mail/mail.ts Simplified conditional logic for assigning subject, paragraph, and lastParagraph variables in sendNotificationMail function using logical OR operator.
backend/models/vueformGenerator.ts Changed equality check from == to === in mapSchemaTypeToVueformElement function for strict type comparison.
backend/pdf/travel.ts Simplified logic for processing a string input in PDF generation, using logical OR operator for fallback to an empty string.
common/locales/de.json Added new alert message "conflict": "Konflikt!" to the German localization file.
common/locales/en.json Added new alert message "conflict": "Conflict!" to the English localization file.

Possibly related PRs

🐰 In the garden, changes bloom,
A conflict here, a new error loom.
With checks in place, we clear the way,
No more deletions gone astray!
Hops of joy, let’s celebrate,
A cleaner code, oh, isn’t it great? 🌼

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between dd61b94a1446e28c7094970a37998c7f7576e7be and 1545544b1b9eb453d4c31593b4a35da76a27f91e.
Files selected for processing (1) * backend/controller/uploadController.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1) * backend/controller/uploadController.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
david-loe commented 2 months ago

fixes #97