david-loe / abrechnung

Reisekostenabrechnung inkl. automatischer Pauschalen Berechnung auch für internationale Reisen
GNU Affero General Public License v3.0
12 stars 2 forks source link

Revert "Add TLS for dev setup" #99

Closed david-loe closed 1 month ago

david-loe commented 2 months ago

Reverts david-loe/abrechnung#91

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve the removal of TLS-related configurations across multiple files, including .env.example, README.md, various Traefik configuration files, and the Dockerfile. This results in the elimination of settings and scripts associated with TLS setup, simplifying the overall configuration. The docker-compose.yml file also reflects this by removing the traefik service entirely, indicating a shift away from using Traefik for reverse proxying in this project.

Changes

File(s) Change Summary
.env.example Removed variable TLS_CERT_CN, simplifying the configuration.
README.md Removed section on "TLS in development," eliminating guidance on TLS setup.
dev-tools/traefik/Dockerfile Deleted Dockerfile that defined a Traefik container with TLS setup.
dev-tools/traefik/config.yml Deleted configuration file that defined TLS settings and HTTP routing rules for Traefik.
dev-tools/traefik/gen-certs.sh Deleted script responsible for generating SSL certificates for Traefik.
dev-tools/traefik/traefik.yml Deleted configuration file that defined entry points, providers, and API settings for Traefik.
docker-compose.yml Removed traefik service definition, including build context, labels, and port mappings.

Possibly related PRs

🐰 In a world where TLS is gone,
The rabbit hops, and we move on.
No more certs to generate,
Simplicity is now our fate.
With Traefik's tale now at an end,
We leap ahead, our paths to mend! 🐇✨


:scroll: Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
:inbox_tray: Commits Files that changed from the base of the PR and between 84792564ac36983e13374b2a88952100d0f185f2 and d60d1e4af86bc2102ba6aee0c58ed490bff6301c.
:ledger: Files selected for processing (7) * .env.example (0 hunks) * README.md (1 hunks) * dev-tools/traefik/Dockerfile (0 hunks) * dev-tools/traefik/config.yml (0 hunks) * dev-tools/traefik/gen-certs.sh (0 hunks) * dev-tools/traefik/traefik.yml (0 hunks) * docker-compose.yml (0 hunks)
:zzz: Files not reviewed due to no reviewable changes (6) * .env.example * dev-tools/traefik/Dockerfile * dev-tools/traefik/config.yml * dev-tools/traefik/gen-certs.sh * dev-tools/traefik/traefik.yml * docker-compose.yml
:toolbox: Additional context used
Markdownlint
README.md
15-15: null Bare URL used (MD034, no-bare-urls)
:mute: Additional comments not posted (3)
README.md (3)
`14-14`: **LGTM: Improved document structure** The addition of blank lines enhances the readability of the README by creating better visual separation between sections. Also applies to: 17-17 --- `15-15`: **Ignore static analysis warning for video embed URL** The static analysis tool flagged a bare URL on this line. However, this URL is part of a video embed, which is a common and accepted practice in markdown files. Changing this to a linked format might break the video embed functionality.
:toolbox: Tools
Markdownlint
15-15: null Bare URL used (MD034, no-bare-urls)
--- Line range hint `1-17`: **Verify consistency of TLS removal across the project** The removal of the "TLS in development" section from the README is consistent with the PR's objective to revert TLS-related changes. However, please ensure that: 1. All related configuration files (e.g., `.env.example`, Traefik configs) have been updated accordingly. 2. Any other documentation referencing TLS setup for development has been updated or removed. 3. Developers are informed about this change and its implications for their local development setup. To verify the complete removal of TLS-related configurations, run the following script: This script will help ensure that all TLS-related configurations have been consistently removed across the project.
:toolbox: Tools
Markdownlint
15-15: null Bare URL used (MD034, no-bare-urls)
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
:heart: Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
:placard: Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.