search

david-macmahon / Blio.jl

5 stars 2 forks source link

Unnecessary type alignment warning #4

Open texadactyl opened 2 years ago

texadactyl commented 2 years ago

See Filterbank.jl, line 515, @warn "data in $(fb.name) are not type aligned" _module=nothing _file=nothing

It seems to me that this warning is an unnecessary alarm because the data array can be aligned to start at any .fil file offset.

E.g. The Voyager 1 SIGPROC Filterbank file (.fil) data array starts at offset 382 = 30 modulo 32.

texadactyl commented 2 years ago

Maybe you meant to perform that modulo test on the data size i.e. if fbh[:data_size] % sizeof(eltype) == 0