search

david-mark-llc / jessie

Javascript cross-browser library builder enabling (real) progressive enhancement
http://jessie.herokuapp.com
39 stars 13 forks source link

setTempHtml is not implemented anywhere #234

Open humanchimp opened 11 years ago

humanchimp commented 11 years ago

The method htmlToNodes depends on setTempHtml, but that method is missing

humanchimp commented 11 years ago

can we just patch this via s/setTempHtml/setHtml/g?

adamsilver commented 11 years ago

Not sure about this one - I believe this is a rendition written by @cinsoft - perhaps David can give you more information.

david-mark commented 11 years ago

See the one in My Library (and accompanying discussion in the forum as there is one flaw). I was starting to port it over about a year ago, but haven't had time to work on it since.

On Mon, Sep 2, 2013 at 1:54 PM, Adam Silver notifications@github.comwrote:

Not sure about this one - I believe this is a rendition written by @cinsoft https://github.com/cinsoft - perhaps David can give you more information.

— Reply to this email directly or view it on GitHubhttps://github.com/rassie/jessie/issues/234#issuecomment-23672426 .

humanchimp commented 11 years ago

Looked over your My Library code @cinsoft. Seems pretty straightforward. Not sure what flaw you are referencing, however. I searched for "setTempHtml" and came up with this thread. Is that the one? http://d.pr/jX8T

david-mark commented 11 years ago

Yes indeed. There is no need for the extra logic to handle the SELECT bug or anything to do with insertAdjacentHtml. There is also a bit missing from setTempHtml (or nearby) that disallows setting the HTML of table rows. You'll see...

On Tue, Sep 3, 2013 at 10:47 AM, humanchimp notifications@github.comwrote:

Looked over your My Library code @cinsoft https://github.com/cinsoft. Seems pretty straightforward. Not sure what flaw you are referencing, however. I searched for "setTempHtml" and came up with this thread. Is that the one? http://d.pr/jX8T

— Reply to this email directly or view it on GitHubhttps://github.com/rassie/jessie/issues/234#issuecomment-23717977 .