search

david-mark-llc / jessie

Javascript cross-browser library builder enabling (real) progressive enhancement
http://jessie.herokuapp.com
39 stars 13 forks source link

Builder tidy up #309

Closed web-bert closed 9 years ago

web-bert commented 9 years ago

Changed nodemon call to only watch the builder files Rely on npm env setup so we don't need the path to nodemon as it will be on $PATH Some content in the README Removed unused packages Changed jslint to jshint so strict:false works Removed some unused variables Made style of command.js match the other files

adamsilver commented 9 years ago

:+1:

adamsilver commented 9 years ago

Feel free to merge, and deploy.

web-bert commented 9 years ago

Have you checked the app and cli locally to confirm it still works?

On 13 August 2015 at 09:45, Adam Silver notifications@github.com wrote:

Feel free to merge, and deploy.

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130577656.

adamsilver commented 9 years ago

No. You?

On Thu, Aug 13, 2015 at 9:46 AM, web-bert notifications@github.com wrote:

Have you checked the app and cli locally to confirm it still works?

On 13 August 2015 at 09:45, Adam Silver notifications@github.com wrote:

Feel free to merge, and deploy.

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130577656.

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130578102.

Regards Adam Silver

web-bert commented 9 years ago

I did but it would be good to get another person to check it :-)

On 13 August 2015 at 09:46, Adam Silver notifications@github.com wrote:

No. You?

On Thu, Aug 13, 2015 at 9:46 AM, web-bert notifications@github.com wrote:

Have you checked the app and cli locally to confirm it still works?

On 13 August 2015 at 09:45, Adam Silver notifications@github.com wrote:

Feel free to merge, and deploy.

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130577656.

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130578102.

Regards Adam Silver

— Reply to this email directly or view it on GitHub https://github.com/cinsoft/jessie/pull/309#issuecomment-130578355.

adamsilver commented 9 years ago

Checked locally, all seems okay. Go ahead, merge, mark a release and deploy.