david-pfx / PuzzleScriptNext

A direct successor to PuzzleScript, building on the work of PuzzleScript Plus, Pattern:Script and others.
http://www.puzzlescriptnext.polyomino.com
MIT License
11 stars 4 forks source link

Sprite transform display anomaly (P:S versus PS>) #33

Closed angilbert closed 2 months ago

angilbert commented 4 months ago

Describe the bug Compare these two renditions of the same game: https://clementsparrow.github.io/Pattern-Script/src/play.html?p=b81a790a66fda61d8192888ca2da072d https://puzzlescriptnext.polyomino.com/play.html?demo=patt/hat_tricks Something is awry in the PSNext rendition of the AX group of tagged objects (see screenshot below)

Reproduction Steps Use URLs above

What did you expect would happen? The two games should look identical

OS & Browser version, desktop/mobile MAC Safari & Chrome I've checked java console - there are no errors reported

Screenshots, example projects, other relevant issues, etc.

Screenshot 2024-04-23 at 17 13 53
angilbert commented 4 months ago

I correctly guessed the problem. It's because objects A2-A5 do not explicitly state they are copies of A1 (P:S is clearly more forgiving if you do this). It can be easily fixed in the PSNext editor as shown in the screenshot below. This is a very minor anomaly between the two forks, quite possibly not worth fixing. Although I would still recommend updating the GIST used by "play.html?demo=patt/hat_tricks" so the visuals are correct.

Screenshot 2024-04-23 at 17 22 38
david-pfx commented 4 months ago

Well spotted. I've played that game multiple times and never noticed. I'll fix it if I reasonably can. It's hard to be sure with some of these, because the 'correct' behaviour of P:S is not defined.

david-pfx commented 3 months ago

Fixed in 24e01

david-pfx commented 2 months ago

Post vector rewind. Cannot find any sign it was ever fixed. Bug still present in 24e01.

david-pfx commented 2 months ago

Really fixed in 24f22