david-pfx / PuzzleScriptNext

A direct successor to PuzzleScript, building on the work of PuzzleScript Plus, Pattern:Script and others.
http://www.puzzlescriptnext.polyomino.com
MIT License
11 stars 4 forks source link

Level editor hold down mouse button at edge changes level size multiple times #44

Open Stingby12 opened 4 months ago

Stingby12 commented 4 months ago

Describe the bug If you hold down the mouse button while editing the level, you'll repeatedly change the size of the level. I keep accidentally changing the level size to 1*1 every time I delete an object somewhere.

Reproduction Steps Self-explanatory.

What did you expect would happen? Work like regular PuzzleScript. Even PuzzleScript+ doesn't have this bug either.

OS & Browser version, desktop/mobile Why would you make a PuzzleScript game on mobile ? Anyways it's the same problem there.

david-pfx commented 4 months ago

Sorry, cannot reproduce. Looks like I need those repro steps:

Stingby12 commented 3 months ago

Just hold the mouse button. Literally everytime you are at the edge of the level and you hold it replicates the action.

david-pfx commented 3 months ago

No, nothing like this happens when I try it. Maybe I'm missing a step.

So the steps are:

  1. Open a game in the editor
  2. Run the game
  3. Press E to enter level editing mode
  4. Click...where exactly? Is the plus sign visible?
  5. What happens, exactly? Would a screenshot showing help?
Stingby12 commented 2 months ago

I'm going to rewrite everything because reading this again I found a lot of issues. Hopefully this is better to understand.

Describe the bug If you hold down the mouse button while editing the size of the level, you can repeatedly change the size of the level. I keep accidentally changing the level size to 1*1 every time I delete everything in a level or increase the size when I place objects in it.

Reproduction Steps

  1. Open the level editor on a level.
  2. Hold the mouse button on the game screen. Whenever you hold the right click or the left click doesn't matter since it's basically the same results.
  3. If you move over the edge of the level (whenever it shows the plus sign) while still holding the mouse button, the level size changes will occur.

What did you expect would happen? I tried on both PuzzleScript and PuzzleScript Plus and it doesn't seem to happen in here. So I'll just say that what should happen is what should happen when you try that on those two other forks.

OS & Browser version, desktop/mobile Windows 11, Firefox I also tested on my phone for whatever reason and yeah it's the same exact thing

david-pfx commented 2 months ago

Reproduced. The thing you didn't mention was (a) hold down a mouse button (b) move outside the level.

Not obvious how this happens. Will look into it.