search

david-r-edgar / MapSwitcher

Chrome extension to switch between different mapping websites
MIT License
25 stars 7 forks source link

Firefox Port and Version Increase from 0.4.6 --> 0.4.7 #29

Open that-gai-gai opened 3 years ago

that-gai-gai commented 3 years ago

I ported over the extension to firefox and it is working fine. I had to change some things in tippy.min.js. My suggestion is to test on chrome on your side to ensure functionality remains unharmed.

david-r-edgar commented 3 years ago

Thanks for this! It looks like you've modified the minified tippy library. Is this just a new version (if so, which?), or did you make other changes to it? Do you have a link to the original source?

I understand that submission to the mozilla add-ons store requires the actual unminified source to be available for review, with correct version numbers and links (https://extensionworkshop.com/documentation/publish/third-party-library-usage/), so I think there are a few further changes necessary (or at least details to be researched) for a number of libraries before I can actually submit this for signing.

that-gai-gai commented 2 years ago

I am just now seeing this...I'll double check about the versioning and get back with you this weekend!