search

david-rc-dayton / pious_squid

An astrodynamics library, for the Dart ecosystem.
MIT License
7 stars 1 forks source link

Possible Bug in Hill EQCM Coordinates #3

Closed thkruz closed 6 months ago

thkruz commented 9 months ago

https://github.com/david-rc-dayton/pious_squid/blob/d3579648da9be426c76c910e4c12c460171e86bd/lib/src/coordinate/hill.dart#L313C5-L315C6

result is in Km/s and this branch is converting it into m/s. The problem is that it gets converted into m/s again on the next line. Unless I am missing something you will end up with mm/s whenever the ignoreCrosstrack flag is true.

david-rc-dayton commented 9 months ago

Was that line a return statement at one point? Yes. Did I forget to remove the m/s scaling on that line after getting rid of the return statement? Also yes.

...I will fix that.

david-rc-dayton commented 6 months ago

Fixed in 0.3.0 release.