Edits needed to the Dockerfile

xxl007 commented 3 months ago

Hi, amazing work. Thanks for this!

The container fails to build when running the build.sh script, with the following error:

Step 35/43 : COPY ../3rd_party/nvdiffrast/docker/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json
COPY failed: forbidden path outside the build context: ../3rd_party/nvdiffrast/docker/10_nvidia.json ()

Following actions fix the build:

Copying the folder nvdiffrast to the build folder:

cd docker
cp -r ../3rd_party/nvdiffrast/ .

Adding minor changes to the docker/Dockerfile:

# install nvdiffrast
COPY docker/nvdiffrast/docker/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json

RUN pip install --upgrade pip
RUN pip install imageio imageio-ffmpeg

COPY docker/nvdiffrast/nvdiffrast /tmp/nvdiffrast/
COPY docker/nvdiffrast/README.md docker/nvdiffrast/setup.py /tmp/
RUN cd /tmp && pip install .

david-svitov commented 3 months ago

Hi!

Thanks for your detailed comments on fixing the docker file. However, I am unable to reproduce the error. The paths to 10_nvidia.json in the error message and in the dockerfile are different:

https://github.com/david-svitov/HAHA/blob/42bd784670eb6a9f1c74c1fef5c8a2532174f8b2/docker/Dockerfile#L109

Could you provide more details? Have you changed the dockerfile?

xxl007 commented 3 months ago

Updated the error message that occurs when running the build.sh script (without altering the Dockerfile). As the message suggest, the error seems to occur because 10_nvidia.json is not in the build context.

david-svitov commented 3 months ago

This is strange. I see this file in the nvdiffrast repository, it shouldn't cause an error.

I'll leave this issue open. If anyone has the same problem, please comment.

david-svitov / HAHA

Edits needed to the Dockerfile #2