david-swift / Memorize

Study flashcards in a native GNOME app
https://flathub.org/apps/io.github.david_swift.Flashcards
GNU General Public License v3.0
87 stars 9 forks source link

Reorganizing header bar buttons in "main" flash card view #27

Closed bragefuglseth closed 5 months ago

bragefuglseth commented 5 months ago

One last design suggestion: With the design suggested in #24, there would be some leftover space in the header bar of the main "flash card" view of sets. Since deleting and exporting a set aren't really actions that edit the set, I think it would make sense to move them out into the header bar there instead. The edit button could also be moved there, to make it clear that it edits the whole set, not just the name:

Skjermbilde fra 2024-03-18 22-38-02

In addition to being semantically better, this would make it a lot quicker to delete unwanted sets.

If more actions that apply to the entire set are added in the future, we could group them together with deleting and exporting in a three-dot popover menu instead.

david-swift commented 5 months ago

Thanks! I really like that concept, I'll look into implementing it once I'm less busy.

david-swift commented 5 months ago

Screenshot from 2024-03-21 21-46-30

I implemented it in 2229b60.

bragefuglseth commented 5 months ago

How exciting! :grinning: