david-swift / Memorize

Study flashcards in a native GNOME app
https://flathub.org/apps/io.github.david_swift.Flashcards
GNU General Public License v3.0
87 stars 9 forks source link

Esc key should close search bar #44

Closed rene-coty closed 4 months ago

rene-coty commented 4 months ago

Describe the bug

When using the search button on the main page and in the edit view (see additional context below), it's not possible to close the search field/action by pressing the Esc key - which is the usual (and most practical) way to do it. You have to click manually on the search button to deactivate search.

To Reproduce

  1. Click 'Search' in the app menu
  2. Try pressing Esc key to close the search action/field : nothing happens

Expected behavior

Esc key should terminate/escape the search action

Additional context

Capture d’écran du 2024-04-17 23-01-17 Capture d’écran du 2024-04-17 23-02-00

david-swift commented 4 months ago

Thanks! Fixed in 99847b7.