david-swift / Memorize

Study flashcards in a native GNOME app
https://flathub.org/apps/io.github.david_swift.Flashcards
GNU General Public License v3.0
87 stars 9 forks source link

Pressing Enter should create a tag directly from the entry field #6

Closed rene-coty closed 6 months ago

rene-coty commented 6 months ago

Describe the bug

Pressing the Enter key should create a Tag directly from the input field filled in by the user, without having to search for another interface button to save it.

To Reproduce

Currently you have to tap the + button once, then type and press the + button again, which is not very intuitive (and creates another tag)…

Expected behavior

When creating a Tag, you should only have to tap the + button once, then type and press Enter

Additional context

Capture d’écran du 2024-02-25 14-21-19

david-swift commented 6 months ago

Thanks so much for opening this issue, @rene-coty! I've fixed it in the commit 4d8247b. The newly added tag (or keyword, both views are built on the same code) now additionally also gets the focus. A tag/keyword can be added by pressing enter inside of a tag/keyword entry.

Screencast from 2024-02-25 14-49-43.webm

david-swift commented 6 months ago

@rene-coty, thanks again so much for your suggestion! I applied the same principle to the navigation in the edit view (and creating new flashcards), and it feels so natural!

Screencast from 2024-02-25 15-50-43.webm

david-swift commented 6 months ago

Ah sorry, I think I misunderstood this issue (I think the unrelated changes improve the UX as well). Currently, there's no requirement to press enter after having typed a tag's name, the tags view gets updated automatically. Since this does not seem to be intuitive, do you think a UI more similar to the one seen in Errands would be a better approach?

Screencast from 2024-02-25 21-27-38.webm

rene-coty commented 6 months ago

Maybe I wasn't very clear since I'm not a native English speaker, but I think you did answer my issue though :) it's more easy now to browse the UI fluently with a keyboard

david-swift commented 6 months ago

Oh :see_no_evil: :rofl: - I'll close the issue again then.