david-swift / Memorize

Study flashcards in a native GNOME app
https://flathub.org/apps/io.github.david_swift.Flashcards
GNU General Public License v3.0
87 stars 9 forks source link

Too long tag names make the pop-up scrollable #8

Closed rene-coty closed 6 months ago

rene-coty commented 6 months ago

Describe the bug

When there is a long tag name, it will be displayed with scrollbars in the appearing pop-up instead of being cleanly cut-off, which spoils the aesthetics of the app (and makes navigating through tags a bit unpleasant)

To Reproduce

  1. Create a long Tag name (e.g. something in French 😇)
  2. Click the Tag button next to a FlashCard
  3. Tag name is partially hidden, with scrollbars appearing

Expected behavior

I don't really expect the pop-up to exactly fit the size of the tag (it could be too long), but a more clean solution would be to make it a bit adaptive, with a maximum size beyond which the words are simply cut with '…'

Additional context

Capture d’écran du 2024-02-25 19-31-32

david-swift commented 6 months ago

I fixed it in the commit 9fc0ab1. Screenshot from 2024-02-26 06-14-02 Screenshot from 2024-02-26 06-14-17 Screenshot from 2024-02-26 06-15-08

The popup's size is static and does not expand at all, as this would be difficult to implement with the FlowBox (which holds the tags) that seems to always take up the maximum width. I dont think expanding would enhance the usability very much, so I did not implement it. Removing the scroll view does make it look much more appealing, thanks!