search

david-szabo97 / grav-plugin-admin-addon-revisions

An extension for Grav Admin plugin which adds revisions for pages.
MIT License
11 stars 8 forks source link

Plugin is slowing down the entire admin area #18

Closed codiflow closed 5 years ago

codiflow commented 6 years ago

Unfortunately after activating this addon every request in the admin area takes more than 100% longer than it took before. That drives me nuts... :/

This is a list of all activated plugins:

I'm running the newest version of GRAV v1.5.3

I was using the Chromium Network panel to take the time.

With your plugin activated loading "/admin/pages" takes: image

With your plugin deactivated loading "/admin/pages" takes: image

And here are my plugin settings: image

I think the issue is because you render the page "twice" on php side so it takes longer. Is it possible to disable this for the admin area and activate it for the editable pages only?

david-szabo97 commented 6 years ago

I am not sure about this. Also what does "render the page twice" mean? The plugin isn't doing anything until you save a page. I tried to reproduce, but I am getting the same loading speed.

codiflow commented 6 years ago

I will have a more detail look at it later. Stay tuned.

codiflow commented 6 years ago

After I activated Caching of the Admin Plugin the problem seems to be gone.

I'll keep an eye on this.