Closed CSixtyFour closed 7 years ago
Hi there!
I appreciate your PR. These are my concerns:
Update admin-addon-revisions.php
as commit message doesn't include any information about the changes. It's a rather small change so we can easily state what this commits do in the message rather than in the description. Something like Show debug messages based on configuration
would be more informative.
I would prefer something like
$debugEnabled = $this->config->get(self::CONFIG_KEY . '.debug');
This line is totally unneccessary
//Else no debugMessage output
Missing spaces between conditional statement parantheses and brackets.
if($admin_show_debug){
->
if ($debugEnabled) {
Drop any "addMessage" lines if show debug messages has been enabled so as to reduce output messages without messing with any of the plugin functionality