Authentication for Liferay bundle fetching

[sustacek]

Hi David,

I saw that in recent commit, you changed the way how the Liferay bundle is fetched, from Maven-based properties (groupId, artifactId, version + repo url) to simply URL pointing to zip: https://github.com/david-truong/liferay-workspace/commit/922958f58818fe8497f1091972027e2f29d66976

I was wondering, are there any plans to allow authentication to be used with fetching the bundle? For Liferay Workspace EE, we will very likely need to get EE bundle from some restricted locations (Maven repository, ftp etc.) so I was wondering if you plan to add support for this in the base Liferay Workspace.

I though about it and I think the simplest would be to use the older Maven-based configuration and allow Liferay Workspace users to define additional repository in their Gradle build, and make sure it will be tried to get the bundle. Users can then use whatever authentication they want (as long as it will be supported by Gradle for given repository).

Another possibility would be to add new configuration keys for to gradle.properties recognized by the Workspace plugin (username & password) and use them to fetch the bundle.url if they are provided.

[gamerson]

hey @sustacek we have support for authentication of DXP bundles now. See my commit here for how to do it

https://github.com/david-truong/liferay-workspace/pull/58/commits/68459ac2d1cccec7339d26fe39f72fa89182a2f7

Then all you need to do it edit your ~/.gradle/gradle.properties and add

downloadUsername=bilbo.baggins
downloadPassword=RiddlesInTheDark

This username/password should be the liferay.com username/password, and the customer should use the account that has Subscription access. Right @david-truong ?

[sustacek]

Thanks Greg! I already dug into the source code of the workspace plugin earlier and found very similar solution, but thanks for confirmation.