david-vanderson / dvui

Other
431 stars 36 forks source link

Added OpenDyslexic #122

Closed VisenDev closed 2 months ago

david-vanderson commented 2 months ago

This looks pretty good, some questions:

VisenDev commented 2 months ago
  • Looks like we only need the otf versions, do we need the other versions? Also the pdf?

Probably not, I can remove those

  • When I'm testing them, the letter spacing seems too large. Do you think so?

I'm not sure, I would compare it with how the font appears on https://opendyslexic.org/ to see if we have any dvui-specific issues or if that is just how the font looks

  • Should we have the bold and bold-italic versions loaded by default as well?

Yes, I can add those.

  • In the pdf, some glyphs look like they have colored parts (like the capital A on page 3). Am I seeing that correctly? If so can you add an issue to track supporting colors in font glyphs?

Yes, also on page 18 several glyphs have colored parts as well. I'll create an issue for this.

david-vanderson commented 2 months ago

I'll take a second look at the letter spacing.

Thank you!