search

david-vloedman-401-advanced-javascript / 401-lab-15

MIT License
0 stars 0 forks source link

Heroku, Swagger #2

Open david-vloedman opened 4 years ago

david-vloedman commented 4 years ago

@natkiypie @doug97703

I updated the heroku, it should be working for you to test now.

Concerning the swagger, I do have it. I'm not sure what the points missing concerning that are for. Could you clarify? Thanks.

natkiypie commented 4 years ago

Deployment still not working. You will have to include a link to your Swagger docs in your README.md.

david-vloedman commented 4 years ago

Are you sure you’re on the right branch? Heroku works for me

david-vloedman commented 4 years ago

The user routes are under /v1/signup not /api/v1. The actual data routes are under /api/v1/products for example

doug97703 commented 4 years ago

@david-vloedman the correct heroku address is https://auth-api-15.herokuapp.com right? That's what's linked on the lab15 branch of this repo. /api/v1/signup and /v1/signup are both returning errors for me. screenshot017

david-vloedman commented 4 years ago

@doug97703 @natkiypie I pushed out a new deployment, I don't know if it was not the newest or what. It works currently, but so did the last one. Also, I added a link to the swagger in the readme. I wasn't sure what that meant, because I've never done that in the past but got full points. I asked about it a while back and I thought it was just having the json and utilizing it in the application w/ the middleware.