david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Draw function test cases (data types and manual layout) #30

Closed sarahsonder closed 5 months ago

sarahsonder commented 5 months ago

Proposed Changes

Added tests for the draw function, covering data types and manual layouts.

Previously, there was only one general snapshot test. The purpose of this PR is to write tests that check for more specific behaviours.

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

After opening your pull request:

Questions and Comments

Yoonie will be covering automatic layouts and custom styling!

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9164741035

Details


Totals Coverage Status
Change from base Build 9164734129: 25.4%
Covered Lines: 376
Relevant Lines: 423

💛 - Coveralls