david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Highlight box bug #38

Closed yoonieaj closed 4 months ago

yoonieaj commented 5 months ago

Proposed Changes

Fixed a bug where the fill colour of boxes covered and hid the text in the box. This was done by changing the order in which elements are drawn. Also changed the implementation of the hide style option. Now, this option sets text opacity to zero (before, it covered the text with a white box), so that the hide style option still works after the above bug fix.

...

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

After opening your pull request:

Questions and Comments

I went over the snapshots and it seems like they were failing because of the changed order in which elements were drawn, so I decided to update the snapshots and have included the updated versions in this PR.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9370168024

Details


Totals Coverage Status
Change from base Build 9327208107: 0.02%
Covered Lines: 381
Relevant Lines: 424

💛 - Coveralls