david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Change "class" attribute to "type" for objects #39

Closed sarahsonder closed 4 months ago

sarahsonder commented 4 months ago

Proposed Changes

The purpose of this pull request is to change the class attribute to type when drawing objects. Previously, all objects, functions, and stack frames shared a class attribute when creating input. However, for objects, the name attribute actually refers to the type of the object. The changes in this pull request not only serve to better adhere to the actual meaning of the input values, but to also differentiate between drawing objects and stack frame/functions.

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality) X
πŸ› Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
πŸ“š Documentation update (change that only updates documentation) X
πŸ“¦ Dependency update (change that updates a dependency)
πŸ”§ Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

After opening your pull request:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9327057573

Details


Totals Coverage Status
Change from base Build 9307871423: 0.0%
Covered Lines: 380
Relevant Lines: 423

πŸ’› - Coveralls