david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Embed isClass and stack_frame as types #40

Closed sarahsonder closed 4 months ago

sarahsonder commented 4 months ago

Proposed Changes

This PR removes the isClass and stack_frame attributes and embeds them as the types .class and .frame. In addition, the input for the blank type has been changed from BLANK to .blank, and blank stack frames are now denoted by the type .blank-frame. These changes serve to streamline the process of drawing objects, classes, and stack frames while also reducing the complexity of the user input.

Type of Change

Type Applies?
šŸšØ Breaking change (fix or feature that would cause existing functionality to change) X
āœØ New feature (non-breaking change that adds functionality) X
šŸ› Bug fix (non-breaking change that fixes an issue)
šŸŽØ User interface change (change to user interface; provide screenshots)
ā™»ļø Refactoring (internal change to codebase, without changing functionality)
šŸš¦ Test update (change that only adds or modifies tests) X
šŸ“š Documentation update (change that only updates documentation) X
šŸ“¦ Dependency update (change that updates a dependency)
šŸ”§ Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

After opening your pull request:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9408747160

Details


Totals Coverage Status
Change from base Build 9376313216: 0.7%
Covered Lines: 386
Relevant Lines: 427

šŸ’› - Coveralls