Closed yoonieaj closed 4 months ago
Totals | |
---|---|
Change from base Build 9327208107: | 0.0% |
Covered Lines: | 380 |
Relevant Lines: | 423 |
show_indexes
and style
can both be optional as well.Style
attributes to be optional 👍 Totals | |
---|---|
Change from base Build 9376313216: | 0.0% |
Covered Lines: | 381 |
Relevant Lines: | 424 |
Added type interfaces and type annotations for functions and constants in style.ts
. This should improve code organisation/readability.
...
(Write an X
or a brief description next to the type or types that best describe your changes.)
Type | Applies? |
---|---|
🚨 Breaking change (fix or feature that would cause existing functionality to change) | |
✨ New feature (non-breaking change that adds functionality) | |
🐛 Bug fix (non-breaking change that fixes an issue) | |
🎨 User interface change (change to user interface; provide screenshots) | |
♻️ Refactoring (internal change to codebase, without changing functionality) | x |
🚦 Test update (change that only adds or modifies tests) | |
📚 Documentation update (change that only updates documentation) | |
📦 Dependency update (change that updates a dependency) | |
🔧 Internal (change that only affects developers or continuous integration) |
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ]
into a [x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)
Before opening your pull request:
After opening your pull request:
(Include any questions or comments you have regarding your changes.)
Totals | |
---|---|
Change from base Build 9376313216: | 0.0% |
Covered Lines: | 381 |
Relevant Lines: | 424 |
Totals | |
---|---|
Change from base Build 9410692102: | 0.0% |
Covered Lines: | 388 |
Relevant Lines: | 429 |
Totals | |
---|---|
Change from base Build 9410692102: | 0.0% |
Covered Lines: | 388 |
Relevant Lines: | 429 |
Totals | |
---|---|
Change from base Build 9410692102: | 0.0% |
Covered Lines: | 388 |
Relevant Lines: | 429 |
Proposed Changes
Added type interfaces and type annotations for functions and constants in
style.ts
. This should improve code organisation/readability. ...Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
Hello Professor Liu! I have a few questions about the changes I've made so far: