david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Remove double quotes when rendering objects of type None #42

Closed sarahsonder closed 4 months ago

sarahsonder commented 4 months ago

Proposed Changes

The purpose of this PR is to change the rendering of objects of type None. Previously, the value would display as "None", and now it is displayed as None without the double quotes (screenshots included below!). This is to reflect the actual value of None in memory.

Screenshots of your changes For the input `{ "type": "None", "id": 13, "value": "None" }`, the first image is the previous output and the second image is the current output. ![image](https://github.com/david-yz-liu/memory-viz/assets/55766946/4e7f327e-4d42-4091-bdb2-c4ddcba7a4a8) ![image](https://github.com/david-yz-liu/memory-viz/assets/55766946/d3f9213b-5550-433b-bf85-272b806b005e)

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
πŸ› Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
πŸ“š Documentation update (change that only updates documentation)
πŸ“¦ Dependency update (change that updates a dependency)
πŸ”§ Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

After opening your pull request:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9408998315

Details


Totals Coverage Status
Change from base Build 9376313216: 0.08%
Covered Lines: 383
Relevant Lines: 426

πŸ’› - Coveralls