david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Update drawPrimitive to remove quotation marks from non-str objects #45

Closed yoonieaj closed 4 months ago

yoonieaj commented 4 months ago

Proposed Changes

Remove quotation marks from all objects that are not of type str, since we don't want to render quotation marks for non str objects.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

After opening your pull request:

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9560362739

Details


Totals Coverage Status
Change from base Build 9558270699: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9574146099

Details


Totals Coverage Status
Change from base Build 9558270699: 0.2%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls