david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Commander cli #47

Closed yoonieaj closed 4 months ago

yoonieaj commented 4 months ago

Proposed Changes

Adopted Commander.js library for the MemoryViz CLI, and added optional --width and --height arguments to specify the width and height of SVGs generated with the CLI. This simplifies the CLI code and adds functionality.

...

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality) X
πŸ› Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
πŸ“š Documentation update (change that only updates documentation)
πŸ“¦ Dependency update (change that updates a dependency)
πŸ”§ Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

After opening your pull request:

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9608043343

Details


Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9636137265

Details


Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9640526770

Details


Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

πŸ’› - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9647281387

Details


Totals Coverage Status
Change from base Build 9647267380: 0.0%
Covered Lines: 388
Relevant Lines: 429

πŸ’› - Coveralls