david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Add --roughjs_config option for MemoryViz CLI #48

Closed sarahsonder closed 3 months ago

sarahsonder commented 4 months ago

Proposed Changes

This pull requests adds the option to configure the options parameter of the draw function.

Sample call: memory-viz <path-to-file> --roughjs-config bowing=3,fill=red,fillStyle=solid

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

After opening your pull request:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9689140202

Details


Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9689383321

Details


Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9706609970

Details


Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls