david-yz-liu / memory-viz

Javascript library for creating beginner-friendly memory model diagrams.
https://www.cs.toronto.edu/~david/memory-viz/demo/
2 stars 7 forks source link

Left margin bug #51

Closed yoonieaj closed 3 months ago

yoonieaj commented 3 months ago

Proposed Changes

This pull request fixes an issue where generating diagrams with large left margins resulted in object boxes being drawn on top of the call stack. Now, objects boxes will always be drawn to the right of the call stack (by a distance equal to the padding set by the user), as expected. ...

Screenshots of your changes (if applicable) Before: ![Screenshot 2024-07-03 160117](https://github.com/david-yz-liu/memory-viz/assets/144498960/f6845a98-0adb-4ac0-a03b-255c567727a1) After: ![Screenshot 2024-07-03 160129](https://github.com/david-yz-liu/memory-viz/assets/144498960/6b7679ab-2e2b-4829-aa62-7d2603b31891)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
πŸ› Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
πŸ“š Documentation update (change that only updates documentation)
πŸ“¦ Dependency update (change that updates a dependency)
πŸ”§ Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

After opening your pull request:

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9784331647

Details


Totals Coverage Status
Change from base Build 9731797619: 0.2%
Covered Lines: 407
Relevant Lines: 438

πŸ’› - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9848228885

Details


Totals Coverage Status
Change from base Build 9731797619: 0.2%
Covered Lines: 407
Relevant Lines: 438

πŸ’› - Coveralls