Closed yoonieaj closed 2 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
demo/src/MemoryModelsMenu.tsx | 6 | 7 | 85.71% | ||
<!-- | Total: | 10 | 11 | 90.91% | --> |
Totals | |
---|---|
Change from base Build 10344924734: | -0.01% |
Covered Lines: | 405 |
Relevant Lines: | 435 |
Hi Professor Liu, below are some notes and questions about this round of changes.
Notes
Testing changes: For tests involving Menu components, I've added a fireEvent
to simulate opening the menu.
New files: When importing the logo, I ran into two problems.
The new files declarations.d.ts
and fileMock.js
, as well as updates to jest.config.ts
are my solutions to the above problems. For the first problem, I referenced this Stack Overflow post and the second problem was solved using ChatGPT. Please let me know if you would like me to implement new solutions.
Questions
Input Layout: Since we tried our best to follow the existing structure of the code, we decided not to change the layout of the input in this update. However, we are wondering if we could move the Sample Inputs
and Rendering Options
menus to one row (instead of the two components sandwiching the file input). Please let us know if this change makes sense and if it's ok for us to use MemoryModelsSample.tsx
in MemoryModelsUserInput.tsx
.
Menu Components: There are curently two Menu components, one in MemoryModelsSample.tsx
for sample inputs and another in MemoryModelsUserInput.tsx
for rendering options. At the moment, there is some duplicate code. Should I refactor the code and create a new MemoryModelsMenu
component?
@yoonieaj and @sarahsonder good work; I'll do a full review soon, but in response to your immediate questions:
MemoryModelsMenu
component is a good idea
Proposed Changes
Changed the website design to have a horizontal layout and to include the MemoryViz logo.
Website screenshot
![image](https://github.com/user-attachments/assets/47c1c1ab-7da2-47f2-ab7f-26fb271d062c)Type of Change
Checklist
Before opening your pull request:
After opening your pull request: