Previously, if a user loaded a file and closed the dialog, after re-opening the dialog they would still be able to load in the previously uploaded file. This pull requests fixes this behaviour so the dialog works as expected (i.e., closing the dialog also clears the uploaded file, and the user will not be able to load it in if they re-open the dialog.)
...
Screenshots of your changes (if applicable)
Type of Change
(Write an X or a brief description next to the type or types that best describe your changes.)
Type
Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)
Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)
Before opening your pull request:
[x] I have performed a self-review of my changes.
Check that all changed files included in this pull request are intentional changes.
Check that all changes are relevant to the purpose of this pull request, as described above.
[x] I have added tests for my changes, if applicable.
This is required for all bug fixes and new features.
[ ] I have updated the project documentation, if applicable.
This is required for new features.
[ ] If this is my first contribution, I have added myself to the list of contributors.
[x] I have updated the project Changelog (this is required for all changes).
After opening your pull request:
[x] I have verified that the CI tests have passed.
[x] I have reviewed the test coverage changes reported by Coveralls.
Proposed Changes
Fixes a bug with the file input dialog.
Previously, if a user loaded a file and closed the dialog, after re-opening the dialog they would still be able to load in the previously uploaded file. This pull requests fixes this behaviour so the dialog works as expected (i.e., closing the dialog also clears the uploaded file, and the user will not be able to load it in if they re-open the dialog.)
...
Screenshots of your changes (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)